test: add E2E tests for editor auto-save persistence (#221)#228
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zacharias-ona
commented
Apr 18, 2026
…ition The waitForContentSave promise was created after typing finished. If the 500ms debounce fired before Playwright registered the listener, the PATCH response would be missed causing a flaky 10s timeout. Matches the pattern used in e2e/search.spec.ts. Co-authored-by: Ona <no-reply@ona.com>
Collaborator
Author
|
✅ UI verification skipped — this PR only adds E2E test files ( |
Collaborator
Author
|
✅ Post-merge verification skipped — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #221
What
Adds two E2E tests verifying the editor auto-save behavior:
How
authenticatedPagefixture andnavigateToEditorPagehelper (each test gets a fresh page)./rest/v1/pages, methodPATCH, 2xx status) before reloading — same pattern used ine2e/search.spec.ts.Date.now()suffix in the typed text to avoid collisions between parallel runs.Testing
pnpm lint✅pnpm typecheck✅pnpm test— 252 tests pass ✅pnpm test:e2e -- e2e/editor-auto-save.spec.ts— 2 tests pass ✅